Add Harvester to workspace kubeconfig #7456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

roboquat merged 1 commit into main from mads/add-harvester-to-kubecontext

Jan 6, 2022

Contributor

mads-hartmann commented Jan 5, 2022 •

edited

Loading

Description

This extends our workspace tasks to updates the workspace kubeconfig to also include a context for Harvester. This will give all Gitpod developers easy access to the Harvester clusters through kubectx.

Related Issue(s)

Fixes #7469

How to test

Unfortunately testing this is a bit manual right now due to a bug in our incremental prebuild (see #7475). So the best you can do is start a workspace and run the script and verify that kubectx shows harvester as well as dev:

dev/preview/download-and-merge-harvester-kubeconfig.sh
kubectx
# should show dev and harvester
kubectl get ns 
# should show a bunch of preview-* namespaces

I tested the behaviour of the script for users who don't have core-dev access by creating another GitHub user and running the script. I got the following output:

gitpod /workspace/gitpod $ ./dev/preview/download-and-merge-harvester-kubeconfig.sh 
[Thu 06 Jan 2022 01:43:54 PM UTC] The workspace isn't configured to have core-dev access. Exiting.

Release Notes

NONE

Documentation

N/A

roboquat added release-note-none do-not-merge/work-in-progress labels

mads-hartmann changed the title ~~WIP: Experiment~~ Add Harvester to workspace kubeconfig

Contributor

github-actions bot commented Jan 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

roboquat added the size/S label

Contributor

github-actions bot commented Jan 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

3 similar comments

Contributor

github-actions bot commented Jan 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

Contributor

github-actions bot commented Jan 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

Contributor

github-actions bot commented Jan 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

mads-hartmann commented

View reviewed changes

scripts/preview/download-and-merge-harvester-kubeconfig.sh Outdated Show resolved Hide resolved

mads-hartmann commented

View reviewed changes

scripts/preview/download-and-merge-harvester-kubeconfig.sh Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Jan 6, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

roboquat added size/M and removed size/S labels

Contributor

github-actions bot commented Jan 6, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

2 similar comments

Contributor

github-actions bot commented Jan 6, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

Contributor

github-actions bot commented Jan 6, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

jankeromnes mentioned this pull request

Incremental Prebuilds can sometimes execute an outdated config #7475

Closed

Contributor

github-actions bot commented Jan 6, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.


          Add Harvester kubectl context to kubeconfig

883d56f

mads-hartmann force-pushed the mads/add-harvester-to-kubecontext branch from 985843b to 883d56f Compare

January 6, 2022 13:54

Contributor

github-actions bot commented Jan 6, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

mads-hartmann self-assigned this

mads-hartmann marked this pull request as ready for review

January 6, 2022 13:55

roboquat removed the do-not-merge/work-in-progress label

meysholdt self-requested a review

January 6, 2022 14:03

Member

meysholdt commented Jan 6, 2022

Code looks good and works like a charm :-D

/lgtm
/approve

roboquat assigned meysholdt

roboquat added the lgtm label

Contributor

roboquat commented Jan 6, 2022

LGTM label has been added.

Git tree hash: 91a0186f6ed642c1954cdd9bc8200b000acf0776

meysholdt added the approved label

Contributor

roboquat commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: meysholdt

Associated issue: #7469

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roboquat merged commit c732acb into main

roboquat deleted the mads/add-harvester-to-kubecontext branch

January 6, 2022 14:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved release-note-none size/M